[Messenger] Add Beanstalkd bridge #36582

X-Coder264 · 2020-04-25T20:25:00Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets
License	MIT
Doc PR

On a project at work we use Beanstalkd and we wanted to start using Messenger with it so I've written this bridge/transport. Any feedback is highly appreciated.

noniagriconomie · 2020-04-26T09:42:46Z

src/Symfony/Component/Messenger/Bridge/Beanstalkd/Transport/BeanstalkdSender.php

+    private $connection;
+    private $serializer;
+
+    public function __construct(Connection $connection, SerializerInterface $serializer)


Serializer can be nullable here no?

X-Coder264 · 2020-08-08T20:36:24Z

PR rebased with master.

I don't understand why the Travis PHP 7.2 build fails with the message PHP Fatal error: Class 'Pheanstalk\Contract\PheanstalkInterface' not found in /home/travis/build/symfony/symfony/src/Symfony/Component/Messenger/Bridge/Beanstalkd/Tests/Transport/ConnectionTest.php on line 42 even though Pheanstalk is required by the package. The 7.3 and 7.4 jobs are passing.

I've been using it for months on production and it is working great.

fabpot

Haven't had time to do a full review. Just spotted one change for now.

fabpot · 2020-08-11T16:00:51Z

src/Symfony/Component/Messenger/composer.json

@@ -19,6 +19,7 @@
        "php": ">=7.2.5",
        "psr/log": "~1.0",
        "symfony/amqp-messenger": "^5.1",
+        "symfony/beanstalkd-messenger": "^5.2",


Should be removed. The idea is to add it only when needed.We do have AMQP for BC reasons.

Oh right, removed.

fabpot

LGTM (with some very minor comments)

fabpot · 2020-08-12T06:39:56Z

src/Symfony/Component/Messenger/Bridge/Beanstalkd/README.md

@@ -0,0 +1,12 @@
+Beanstalkd Messenger
+===============


Missing some = chars

I've added the missing = chars.

src/Symfony/Component/Messenger/Bridge/Beanstalkd/README.md

fabpot · 2020-08-12T06:41:13Z

src/Symfony/Component/Messenger/Bridge/Beanstalkd/Transport/Connection.php

+     * * ttr: the message time to run before it is put back in the ready queue (in seconds)
+     */
+    private $configuration;
+


blank line can be removed

fabpot

@X-Coder264 Can you work on fixing the test now? I suppose that we need to install Beanstalkd on Travis.

X-Coder264 · 2020-08-13T07:19:27Z

@fabpot You mean this failure? https://travis-ci.org/github/symfony/symfony/jobs/717325508
This happens only on the PHP 7.2 build, but I don't understand why since the Pheanstalk library is required by the bridge.
On the PHP 7.4 build I can see

cd src/Symfony/Component/Messenger/Bridge/Beanstalkd

+'[' -e composer.lock ']'

+composer install --no-progress --no-suggest --ansi

Loading composer repositories with package information

Installing dependencies (including require-dev) from lock file

Package operations: 7 installs, 0 updates, 0 removals

  - Installing pda/pheanstalk (v4.0.0): Downloading (100%)

  - Installing psr/log (1.0.0): Loading from cache

  - Installing symfony/messenger (v4.4.0): Loading from cache

  - Installing symfony/inflector (v3.4.0): Loading from cache

  - Installing symfony/property-access (v4.4.0): Loading from cache

  - Installing symfony/polyfill-ctype (v1.8.0): Loading from cache

  - Installing symfony/serializer (v4.4.0): Loading from cache

+/home/travis/build/symfony/symfony/phpunit --exclude-group tty,benchmark,intl-data

And all the Beanstalkd bridge tests pass there.

The PHP 7.2 build does not do that, it just runs

/home/travis/build/symfony/symfony/phpunit --exclude-group tty,benchmark,intl-data src/Symfony/Component/Messenger/Bridge/Beanstalkd

I'm not familiar with your Travis CI setup so I'll have to dig a bit deeper into it to check why composer install doesn't happen on the 7.2 build (from the look of it it seems like the 7.2 build is triggering some other code path in .travis.yml).

fabpot · 2020-08-13T07:40:01Z

@X-Coder264 You need to add "pda/pheanstalk": "^4.0", in the require-dev section of the main/root composer.json.

X-Coder264 · 2020-08-13T07:44:58Z

@X-Coder264 You need to add "pda/pheanstalk": "^4.0", in the require-dev section of the main/root composer.json.

Thanks for the tip - I've added it.

fabpot · 2020-08-13T08:11:31Z

Thank you @X-Coder264.

X-Coder264 · 2020-08-13T08:23:46Z

@fabpot Thanks for the merge. I'll create a PR for the documentation this weekend.

X-Coder264 requested a review from sroze as a code owner April 25, 2020 20:25

carsonbot added Status: Needs Review Messenger Feature labels Apr 25, 2020

X-Coder264 force-pushed the beanstalkd-messenger-bridge branch 3 times, most recently from 75032c8 to 30be838 Compare April 25, 2020 21:33

noniagriconomie reviewed Apr 26, 2020

View reviewed changes

X-Coder264 force-pushed the beanstalkd-messenger-bridge branch 2 times, most recently from 1b53ed7 to 2a5bbf3 Compare April 26, 2020 10:53

chalasr added this to the next milestone Apr 26, 2020

X-Coder264 force-pushed the beanstalkd-messenger-bridge branch from 2a5bbf3 to b34ef75 Compare April 28, 2020 22:47

X-Coder264 force-pushed the beanstalkd-messenger-bridge branch 2 times, most recently from 3bd5d9c to de8f23d Compare August 8, 2020 20:24

fabpot requested changes Aug 11, 2020

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Aug 11, 2020

X-Coder264 force-pushed the beanstalkd-messenger-bridge branch from de8f23d to 0c83c5d Compare August 11, 2020 17:01

fabpot approved these changes Aug 12, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Aug 12, 2020

X-Coder264 force-pushed the beanstalkd-messenger-bridge branch from 0c83c5d to e786645 Compare August 12, 2020 16:54

fabpot approved these changes Aug 13, 2020

View reviewed changes

fabpot requested changes Aug 13, 2020

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Reviewed labels Aug 13, 2020

Add Beanstalkd Messenger bridge

8e6d0df

X-Coder264 force-pushed the beanstalkd-messenger-bridge branch from e786645 to 8e6d0df Compare August 13, 2020 07:43

fabpot approved these changes Aug 13, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Aug 13, 2020

fabpot mentioned this pull request Aug 13, 2020

[Messenger] Add Beanstalkd bridge symfony/symfony-docs#14064

Closed

fabpot merged commit 6805d1d into symfony:master Aug 13, 2020

X-Coder264 deleted the beanstalkd-messenger-bridge branch August 13, 2020 08:22

nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020

fabpot mentioned this pull request Oct 5, 2020

Release v5.2.0-BETA1 #38417

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Messenger] Add Beanstalkd bridge #36582

[Messenger] Add Beanstalkd bridge #36582

X-Coder264 commented Apr 25, 2020 •

edited

Loading

noniagriconomie Apr 26, 2020

X-Coder264 Apr 26, 2020

X-Coder264 commented Aug 8, 2020 •

edited

Loading

fabpot left a comment

fabpot Aug 11, 2020

X-Coder264 Aug 11, 2020

fabpot left a comment

fabpot Aug 12, 2020

X-Coder264 Aug 12, 2020

fabpot Aug 12, 2020

X-Coder264 Aug 12, 2020

fabpot left a comment

X-Coder264 commented Aug 13, 2020 •

edited

Loading

fabpot commented Aug 13, 2020

X-Coder264 commented Aug 13, 2020

fabpot commented Aug 13, 2020

X-Coder264 commented Aug 13, 2020

[Messenger] Add Beanstalkd bridge #36582

[Messenger] Add Beanstalkd bridge #36582

Conversation

X-Coder264 commented Apr 25, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

X-Coder264 commented Aug 8, 2020 • edited Loading

fabpot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabpot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabpot left a comment

Choose a reason for hiding this comment

X-Coder264 commented Aug 13, 2020 • edited Loading

fabpot commented Aug 13, 2020

X-Coder264 commented Aug 13, 2020

fabpot commented Aug 13, 2020

X-Coder264 commented Aug 13, 2020

X-Coder264 commented Apr 25, 2020 •

edited

Loading

X-Coder264 commented Aug 8, 2020 •

edited

Loading

X-Coder264 commented Aug 13, 2020 •

edited

Loading