[DI] allow loading and dumping tags with an attribute named "name" #36586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
381bcc1 to
b023e4c
Compare
fabpot
approved these changes
May 3, 2020
|
Thank you @nicolas-grekas. |
Merged
This was referenced Apr 21, 2023
Closed
nicolas-grekas
added a commit
that referenced
this pull request
Apr 21, 2023
…when it does not define their name (MatTheCat) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [DependencyInjection] Do not ignore tags `name` attribute when it does not define their name | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #50081 | License | MIT | Doc PR | N/A Tags `name` attribute is ignored using XML if the tag name is its node content. That means `<tag name="name_attribute">tag_name</tag>` will return a `tag_name` tag without any attribute. This seems to be a regression from #36586. Commits ------- 4c9c688 [DependencyInjection] Do not ignore tags `name` attribute when it does not define their name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor feature added for consistency: using PHP, we can already define tags with an attribute named
"name". But then, we cannot dump such definitions in YAML nor XML since we don't have a syntax to declare such tags in these formats.I spotted this while looking at a dumped container: we already use an attribute named
"name"on two tags:cache.poolandworkflow.definition. Currently, the dumped XML is wrong because of this.This PR enables the following new syntaxes (the current style still works as usual):