Skip to content

Add cache.adapter.redis_tag_aware to use RedisCacheAwareAdapter #36596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2020
Merged

Add cache.adapter.redis_tag_aware to use RedisCacheAwareAdapter #36596

merged 1 commit into from
Aug 13, 2020

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Apr 27, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets https://github.com/orgs/symfony/projects/1#card-33761315
License MIT
Doc PR symfony/symfony-docs#14078

@l-vo l-vo force-pushed the wire_redisTagAwareAdapter branch from 1a831ec to fb1eba1 Compare April 27, 2020 09:13
@nicolas-grekas nicolas-grekas added this to the next milestone Apr 30, 2020
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Apr 30, 2020 •
edited
Loading

Challenge: figure out how to make this work when using a DSN :)

@l-vo
Copy link
Contributor Author

l-vo commented Apr 30, 2020

@nicolas-grekas what do you mean please ? When not using the default provider ? e.g.:

mypool:
    tags: true
    adapter: cache.adapter.redis
    provider: redis://myserver:6379

nicolas-grekas
nicolas-grekas reviewed Apr 30, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nevermind my previous comment, here is a new try)

@l-vo
Copy link
Contributor Author

l-vo commented Apr 30, 2020

Status: needs work

@l-vo l-vo changed the title Use RedisTagAwareAdapter when tags is true and adapter is Redis Add cache.adapter.redis_tag_aware to use RedisCacheAwareAdapter May 4, 2020
@l-vo l-vo force-pushed the wire_redisTagAwareAdapter branch 3 times, most recently from f5a7c15 to 79e949b Compare May 4, 2020 13:32
@l-vo
Copy link
Contributor Author

l-vo commented May 4, 2020

Status: needs review

maxhelias
maxhelias reviewed Jun 16, 2020
View reviewed changes
Copy link
Contributor

@maxhelias maxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase, please ?

@l-vo l-vo force-pushed the wire_redisTagAwareAdapter branch 3 times, most recently from a7a4fb0 to 8218bb8 Compare June 16, 2020 09:50
@l-vo
Copy link
Contributor Author

l-vo commented Jun 16, 2020

can you rebase, please ?

Done 🙂

@maxhelias
Copy link
Contributor

I haven't tried it yet but I like it 😃

nicolas-grekas
nicolas-grekas reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks. Just minor comments and good to go on my side.

@l-vo l-vo force-pushed the wire_redisTagAwareAdapter branch 2 times, most recently from b59b6c4 to 15f8148 Compare June 30, 2020 13:29
@l-vo
Copy link
Contributor Author

l-vo commented Jun 30, 2020

All threads resolved :)

fabpot
fabpot approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the CHANGELOG and rebase on current master? Thank you.

@l-vo l-vo force-pushed the wire_redisTagAwareAdapter branch 6 times, most recently from c9138ea to 861210d Compare August 13, 2020 08:08
@l-vo l-vo force-pushed the wire_redisTagAwareAdapter branch from 861210d to 68d1638 Compare August 13, 2020 08:31
@fabpot
Copy link
Member

fabpot commented Aug 13, 2020

Thank you @l-vo.

@fabpot fabpot mentioned this pull request Aug 13, 2020
Closed
@fabpot fabpot merged commit f99f774 into symfony:master Aug 13, 2020
@l-vo l-vo deleted the wire_redisTagAwareAdapter branch August 13, 2020 09:11
@l-vo l-vo mentioned this pull request Aug 15, 2020
Merged
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Aug 26, 2020
@OskarStark
feature #14078 RedisTagAwareAdapter integration (l-vo)
0ec7295 
This PR was merged into the master branch.

Discussion
----------

RedisTagAwareAdapter integration

Documentation about symfony/symfony#36596

This PR contains documentation on `RedisTagAwareAdapter` (introduced in 4.3) **and** its integration in the fullstack framework (introduced in 5.2).

I created another PR (#14081) with only the documentation about `RedisTagAwareAdapter` that targets 4.4.

Close #14065

Commits
-------

883dc98 RedisTagAwareAdapter integration
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
@javiereguiluz javiereguiluz mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@maxhelias maxhelias maxhelias left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@l-vo @nicolas-grekas @maxhelias @fabpot @carsonbot