[Console][WIP][POC] Add support for arrow keys in QuestionHelper #36700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b73d87 to
e6050fc
Compare
There was a problem hiding this comment.
I don't understand the internals of this, so I can't really review it ... but I hope we can fix it this time. It would be great! Thanks @pierredup.
| throw new MissingInputException('Aborted.'); | ||
| } | ||
|
|
||
| $k = \ord($ret); |
There was a problem hiding this comment.
To make this code maintainable in the future, we could rename some variables. E.g. $k -> $pressedKey or $keyCode,etc.
| $k = \ord(fgetc($inputStream)); | ||
|
|
||
| switch (true) { | ||
| case 67 === $k && $pos < self::strlen($string): |
There was a problem hiding this comment.
Please, let's define some constants to avoid these "magic numbers". E.g.:
case self::ARROW_RIGHT === $pressedKey:
// ...
case self::ARROW_LEFT === $pressedKey:
// ...
// ...There was a problem hiding this comment.
I would highly appreciate that. I read the code and it took some time to dechipher what these numbers are.
|
Closing as this PR has been in a draft state for many months. Feel free to reopen when it's ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for using arrow keys in the QuestionHelper.
The approach here does not depend on
readlineat all (which had some issues and was removed in #17669)This PR also solves some of the issues experienced by @javiereguiluz in #15583, as well as supports decorated messages (which readline doesn't, as per #16458 (comment)).
Before I finish the PR, I just want to get some feedback first if this approach is acceptable.
TODO: