[DependencyInjection] Add abstract_arg() and param() #36775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
May 10, 2020
src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php
Outdated
Show resolved
Hide resolved
f76faf8 to
a94be60
Compare
a94be60 to
1871889
Compare
Tobion
approved these changes
May 10, 2020
stof
approved these changes
May 11, 2020
plozmun
reviewed
May 11, 2020
src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php
Outdated
Show resolved
Hide resolved
|
What do you think about adding this also? function env(string $name): string
{
return '%env('.$name.')%';
} |
src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php
Outdated
Show resolved
Hide resolved
I like the idea, but I think env vars might need a special configurator to get rid of the "complex" strings like |
Honestly, teaching ppl with the real syntax is going to empower them much more than using some extremely specific DSL here. |
stof
approved these changes
May 13, 2020
1871889 to
08ff298
Compare
chalasr
approved these changes
May 22, 2020
08ff298 to
1fd4e8b
Compare
fabpot
added a commit
that referenced
this pull request
Jun 10, 2020
…onfiguration in core (fabpot) This PR was merged into the 5.2-dev branch. Discussion ---------- Use PHP instead of XML as the prefered service/route configuration in core | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes-ish <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | n/a In Symfony 6, I (we?) would want to promote usage of configuration written in PHP instead of YAML. For third-party bundles and core, we should do the same, replacing XML with PHP. Doing so would remove the need for the XML lib for core. The biggest advantage is auto-completion with any modern IDE without explicit support for Symfony, and probably one less thing to learn (how to configure things in YAML/XML). Be warned that it does NOT concern semantic configuration which is much harder. This PR does the work for the Twig bundle as an example. Once we agreed on the CS, the same should then be done for other core bundles both for service configuration and route configuration. Embeds #36775 until it is merged. Commits ------- 0aedd54 [Twig] Move configuration to PHP
|
this misses the update of the changelog of the component |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added abstract_arg() and param() to configuration abstract arguments in PHP DSL.