Skip to content

[Security] Removed "services" prototype node from "custom_authenticator" #36918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2020
Merged

[Security] Removed "services" prototype node from "custom_authenticator" #36918

merged 1 commit into from
May 23, 2020

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented May 23, 2020 •
edited
Loading

Q A
Branch? 5.1
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This was discussed multiple times in the original authenticators PR. It's a bit hacky to implement, but I think it's worth the win on DX side.

I have no idea if and how this should be documented in the CHANGELOG.

Before

security:
    # ...
    firewalls:
        custom_authenticator:
            services:
                - App\Security\MyCustomAuthenticator

After

security:
    # ...
    firewalls:
        custom_authenticator: App\Security\MyCustomAuthenticator

Before

security:
    # ...
    firewalls:
        custom_authenticator:
            services:
                - App\Security\MyCustomAuthenticator
                - App\Security\OtherCustomAuthenticator

After

security:
    # ...
    firewalls:
        custom_authenticators:
            - App\Security\MyCustomAuthenticator
            - App\Security\OtherCustomAuthenticator

@wouterj wouterj changed the title Removed "services" prototype node from "custom_authenticator" [Security] Removed "services" prototype node from "custom_authenticator" May 23, 2020
@wouterj wouterj force-pushed the feature/improve-custom-authenticator-config branch 2 times, most recently from b17c440 to 8a027c2 Compare May 23, 2020 10:19
@wouterj wouterj force-pushed the feature/improve-custom-authenticator-config branch from 8a027c2 to 387ed4a Compare May 23, 2020 10:20
@nicolas-grekas nicolas-grekas added this to the 5.1 milestone May 23, 2020
@fabpot
Copy link
Member

fabpot commented May 23, 2020

Thank you @wouterj.

@fabpot fabpot mentioned this pull request May 23, 2020
Closed
@fabpot fabpot merged commit c403789 into symfony:5.1 May 23, 2020
@wouterj wouterj deleted the feature/improve-custom-authenticator-config branch May 23, 2020 12:29
@fabpot fabpot mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@wouterj @fabpot @nicolas-grekas @carsonbot