-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Added a FrenchInflector for the String component #36929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice thanks.
Here is my quick review.
Did you use any source we should mention to build this?
Thanks for your review, Nicolas! As source, I verified that I forgot no rules with this chapter on NouvelObs and I used a reversed dictionnary to find all nouns finishing with -al.
I will update my PR as soon as I have your recommendations. |
Hi @nicolas-grekas , |
French inflector implements InflectorInterface, it uses regexp and it is tested in the FrenchInflectorTest
Thanks for your review @GromNaN ! It's commited and pushed! |
Thank you @Alexandre-T. |
I read in this blog post this sentence
So I created a FrenchInflector class implementing the InflectorInterface from the String component. This inflector uses regular expressions and it is tested in the FrenchInflectorTest with a lot of the french exceptions.
Changelog has been updated, but I'm not sure I did it in the good paragraph.
I don't know if I should update the symfony/symfony-docs, but I have created an example and I could create a PR with it, if you want.
fabbot.io is detecting a typo, but this is not. The patch done by fabpot suggests to replace the french 'embarras' word by 'embarrass'. I shall not remove or replace it, because "embarras" is an invariant word.