[Notifier] add support for smsapi-notifier #36940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a new feature, can you please rebase to target master? |
ed8ac49 to
f64f197
Compare
|
ok, done I create also a recipe PR here: symfony/recipes#776 |
fabpot
requested changes
Aug 17, 2020
| @@ -50,6 +50,10 @@ | |||
| <tag name="texter.transport_factory" /> | |||
| </service> | |||
|
|
|||
| <service id="notifier.transport_factory.smsapi" class="Symfony\Component\Notifier\Bridge\Smsapi\SmsapiTransportFactory" parent="notifier.transport_factory.abstract"> | |||
| <tag name="texter.transport_factory" /> | |||
| </service> | |||
There was a problem hiding this comment.
Can you move it to the new PHP config file?
05f9beb to
85a578e
Compare
|
You should rebase to get rid of the merge commit. |
fabpot
requested changes
Aug 17, 2020
| @@ -0,0 +1,3 @@ | |||
| /Tests export-ignore | |||
| /phpunit.xml.dist export-ignore | |||
| /.gitignore export-ignore | |||
| return $message instanceof SmsMessage; | ||
| } | ||
|
|
||
| protected function doSend(MessageInterface $message): void |
There was a problem hiding this comment.
As of 5.2, you must return a SentMessage instance.
| $port = $dsn->getPort(); | ||
|
|
||
| if (!$authToken) { | ||
| throw new IncompleteDsnException('Missing path (maybe you haven\'t update the DSN when upgrading from 5.0).', $dsn->getOriginalDsn()); |
There was a problem hiding this comment.
I think this is a copy/paste that should be removed as there is no upgrade here as the provider is new.
45990af to
b1c7e5a
Compare
fabpot
approved these changes
Aug 17, 2020
|
Can you also fix issues reported by fabbot (please, ignore the error message suggestion as this is a false positive)? |
bfd102a to
91c2530
Compare
|
Thank you @szepczynski. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've created integration to notifier to support polish sms operator - smsapi.pl
Here is smsapi-notifier integration: https://github.com/szepczynski/smsapi-notifier. Can you grab this code and make as symfony/smsapi-notifier?
This PR includes changes in notifier and framework-bundle to support smsapi transport as well as other included in notifier component.
Could someone integrate this into notifier component?