Add meaningful message when using ProcessHelper and Process is not installed #37000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a03e8d to
bfc88ac
Compare
Nyholm
approved these changes
May 28, 2020
fabpot
approved these changes
May 29, 2020
bfc88ac to
3ab76e4
Compare
|
Thank you @l-vo. |
This was referenced May 31, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the process helper without the
Processcomponent, a php fatal error is triggered (PHP Fatal error: Uncaught Error: Class 'Symfony\Component\Process\Process' not found). This PR adds a meaningful exception; allowing to display a console error message instead of a raw php fatal error.