Fix invalid char in SQS Headers #37038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
commented
Jun 1, 2020
| $headers = \json_decode($attributes[self::MESSAGE_ATTRIBUTE_NAME]->getStringValue(), true); | ||
| unset($attributes[self::MESSAGE_ATTRIBUTE_NAME]); | ||
| } | ||
| foreach ($attributes as $name => $attribute) { |
There was a problem hiding this comment.
This is need for BC compatibility for people that previously successfully encoded message without special char
chalasr
approved these changes
Jun 1, 2020
stof
reviewed
Jun 1, 2020
| 'StringValue' => $value, | ||
| ]); | ||
| } | ||
| $parameters['MessageAttributes'][self::MESSAGE_ATTRIBUTE_NAME] = new MessageAttributeValue([ |
There was a problem hiding this comment.
This will make inter-operability harder with other tools publishing or reading with SQS. Wouldn't it be better to keep setting attributes directly when their name are valid SQS attribute names ?
fabpot
approved these changes
Jun 3, 2020
|
Thank you @jderusse. |
sstok
reviewed
Jun 7, 2020
| ]); | ||
| } | ||
|
|
||
| dd($parameters); |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 7, 2020
…t (sstok) This PR was merged into the 5.1 branch. Discussion ---------- [Messenger/AmazonSqsBridge] Fixed left-over debug statement | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | | Deprecations? | no | Tickets | Related to #37038 | License | MIT | Doc PR | I noticed whats properly a left-over debugging statement that blocks the code from further execution. /cc @jderusse can you check this (thanks). Commits ------- 8b827e4 Fixed left-over debug statement
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Amazon documnetation header's name have constraints:
a-zA-Z0-9_\.-+ not start/end with a.This PR serialize ALL headers in a single SQS Attribute.