[String] Fix ellipsis of truncate when not using cut option #37054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsche
approved these changes
Jun 2, 2020
apfelbox
reviewed
Jun 2, 2020
| @@ -1450,6 +1450,7 @@ public static function provideTruncate() | |||
| ['foobar...', 'foobar foo', 6, '...', false], | |||
There was a problem hiding this comment.
Sort-of unrelated, but what happens with ['???', 'foobar', 5, '...'],
ie. if ($length + $ellipsisLength) > $stringLength?
It should return the full string then, possibly?
There was a problem hiding this comment.
I'm not sure what you mean, please provide a test case if you want.
There was a problem hiding this comment.
I was not sure whether the length provided to the method is including or excluding the ellipsis. But apparently it is, so the case I talked about can't happen here.
So nvm then 👍
4d0133c to
a2ee6c6
Compare
nicolas-grekas
approved these changes
Jun 11, 2020
| @@ -1450,6 +1450,7 @@ public static function provideTruncate() | |||
| ['foobar...', 'foobar foo', 6, '...', false], | |||
There was a problem hiding this comment.
I'm not sure what you mean, please provide a test case if you want.
|
Thank you @duboiss. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 5.1, we can use a cut option on truncate.
But with this option, we don't have the expected behavior when the entire chain is returned.
Currently:
u('Lorem Ipsum')->truncate(8, '…', false); // 'Lorem Ipsum...'Instead of:
u('Lorem Ipsum')->truncate(8, '…', false); // 'Lorem Ipsum'Thanks to @jmsche for his help.