DateTime validator support for trailing data #37097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefankleff
commented
Jun 4, 2020
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #37094 |
| License | MIT |
xabbuh
reviewed
Jun 4, 2020
| @@ -68,6 +68,8 @@ public function validate($value, Constraint $constraint) | |||
| ->setParameter('{{ value }}', $this->formatValue($value)) | |||
| ->setCode(DateTime::INVALID_TIME_ERROR) | |||
| ->addViolation(); | |||
| } elseif ('Trailing data' === $warning && '+' === substr($constraint->format, -1)) { | |||
There was a problem hiding this comment.
Could there be cases with more than one warning where we don't want to ignore the other ones?
There was a problem hiding this comment.
@stefankleff any idea? Could you please have a look?
There was a problem hiding this comment.
@stefankleff Have you time to have a look at this?
There was a problem hiding this comment.
Sorry, not yet. But I'll try within this week.
There was a problem hiding this comment.
The case is valid, that we have a "+" in the format and we don't want to ignore the other warnings.
I couldn't find a better way than remove the warning from the list of warnings.
I also looked in the underlying c-code and I couldn't find any similar cases to trailing data.
fabpot
approved these changes
Sep 9, 2020
f3b8721 to
27f6e28
Compare
|
Thank you @stefankleff. |
This was referenced Sep 27, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.