[Contracts] Add missing "extra.thanks" entries in composer.json #37121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does that mean only symfony/contracts get's the stars instead of the concrete packages? Why is this better? |
|
Both packages get a star with this directive: the individual contracts + symfony/contracts |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 6, 2020
…er.json (nicolas-grekas) This PR was merged into the 5.2-dev branch. Discussion ---------- [Contracts] Add missing "extra.thanks" entries in composer.json | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Something we forgot and that might help give some more visibility to symfony/contracts. Commits ------- bd04f0c [Contracts] Add missing "extra.thanks" entries in composer.json
nicolas-grekas
added a commit
that referenced
this pull request
Jul 6, 2020
* 4.4: minor #37121 [Contracts] Add missing "extra.thanks" entries in composer.json (nicolas-grekas) [Process] Fix Permission Denied error when writing sf_proc_00 lock files on Windows fix handling null as empty data No need to create an issue when creating a PR [Console] Fixes question input encoding on Windows
nicolas-grekas
added a commit
that referenced
this pull request
Jul 6, 2020
* 5.0: minor #37121 [Contracts] Add missing "extra.thanks" entries in composer.json (nicolas-grekas) [Process] Fix Permission Denied error when writing sf_proc_00 lock files on Windows fix handling null as empty data No need to create an issue when creating a PR Use ">=" for the "php" requirement [HttpClient] Fix promise behavior in HttplugClient [Console] Fixes question input encoding on Windows
nicolas-grekas
added a commit
that referenced
this pull request
Jul 6, 2020
* 5.1: minor #37121 [Contracts] Add missing "extra.thanks" entries in composer.json (nicolas-grekas) [Process] Fix Permission Denied error when writing sf_proc_00 lock files on Windows fix handling null as empty data [Security\Http] Skip remember-me logout on empty token Missing return in loadValuesForChoices method No need to create an issue when creating a PR Use ">=" for the "php" requirement [HttpClient] Fix promise behavior in HttplugClient [Console] Fixes question input encoding on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something we forgot and that might help give some more visibility to symfony/contracts.