[HttpClient] added support for pausing responses with a new pause_handler callable exposed as an info item
#37136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ca9e3b to
418a300
Compare
nicolas-grekas
commented
Jun 8, 2020
Comment on lines
+103
to
+111
| $delay = Loop::defer(static function () use ($duration, $id, &$delay) { | ||
| if (0 < $duration -= microtime(true)) { | ||
| $delay = Loop::delay(ceil(1000 * $duration), static function () use ($id) { Loop::enable($id); }); | ||
| } else { | ||
| $delay = null; | ||
| Loop::enable($id); | ||
| } | ||
| }); |
There was a problem hiding this comment.
PR ready.
Here is the workaround for amphp/amp#319
/cc @kelunik FYI
There was a problem hiding this comment.
@nicolas-grekas The Loop::defer should already be enough, no need to check the actually passed time.
There was a problem hiding this comment.
The time computation accounts for the duration of the tick itself. Since this delay is added at the end of the tick, isn't it?
fabpot
approved these changes
Jun 9, 2020
…ndler` callable exposed as an info item
|
Thank you @nicolas-grekas. |
Merged
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Apr 20, 2021
…oratorTrait (nicolas-grekas) This PR was merged into the 5.2 branch. Discussion ---------- [HttpClient] add doc about extending and AsyncDecoratorTrait About symfony/symfony#36779 and symfony/symfony#37136 Commits ------- f41ef12 [HttpClient] add doc about extending and AsyncDecoratorTrait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code sample will delay sending the request by 2 seconds:
Unlike "competing" HTTP clients written in PHP, this one works while streaming a request/response. This means this PR allows implementing delays before retries but it also enables throttling the streams while still maintaining async/multiplexing.
Returning the handler as an info item saves adding a new method and thus plays well with decorators, without requiring a new dedicated interface.
While this can be used directly, the target use case is within an async-decorator, by using the
AsyncContext::pause()method.As a bonus, this PR improves
NativeHttpClientby making it able to count the maximum number of open connections per-host.