Skip to content

[Mailer] Fixed generator bug when creating multiple transports using Transport::fromDsn #37159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2020
Merged

[Mailer] Fixed generator bug when creating multiple transports using Transport::fromDsn #37159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Symfony/Component/Mailer/Tests/TransportTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,22 @@ public function fromStringProvider(): iterable
];
}

/**
* @dataProvider fromDsnProvider
*/
public function testFromDsn(string $dsn, TransportInterface $transport): void
{
$this->assertEquals($transport, Transport::fromDsn($dsn));
}

public function fromDsnProvider(): iterable
{
yield 'multiple transports' => [
'failover(smtp://a smtp://b)',
new FailoverTransport([new Transport\Smtp\EsmtpTransport('a'), new Transport\Smtp\EsmtpTransport('b')]),
];
}

/**
* @dataProvider fromWrongStringProvider
*/
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Mailer/Transport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class Transport

public static function fromDsn(string $dsn, EventDispatcherInterface $dispatcher = null, HttpClientInterface $client = null, LoggerInterface $logger = null): TransportInterface
{
$factory = new self(self::getDefaultFactories($dispatcher, $client, $logger));
$factory = new self(iterator_to_array(self::getDefaultFactories($dispatcher, $client, $logger)));

return $factory->fromString($dsn);
}
Expand Down