Skip to content

[Console] Fix Docblock for CommandTester::getExitCode #37241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Jun 12, 2020

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT

While doing static analysis on my code, I found a false positive that led me to this little fix.

@Jean85 Jean85 requested a review from chalasr June 12, 2020 13:58
@fabpot
Copy link
Member

fabpot commented Jun 12, 2020

merging in master as it changes the behavior.

@fabpot
Copy link
Member

fabpot commented Jun 12, 2020

Can you rebase on master?

@Jean85 Jean85 changed the base branch from 3.4 to master June 12, 2020 14:38
@Jean85
Copy link
Contributor Author

Jean85 commented Jun 12, 2020

@fabpot done; I had to move it since it was refactored into a trait.

@fabpot
Copy link
Member

fabpot commented Jun 12, 2020

Thank you @Jean85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants