Skip to content

[Security] Add attributes on Passport #37318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2020
Merged

[Security] Add attributes on Passport #37318

merged 1 commit into from
Jun 20, 2020

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jun 17, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets n/a
License MIT
Doc PR not yet

see symfonycorp/connect#95
/cc @wouterj

@chalasr chalasr added this to the next milestone Jun 17, 2020
wouterj
wouterj approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/Symfony/Component/Security/Http/Authenticator/Passport/Passport.php Outdated
*/
public function getAttribute(string $name, $default = null)
{
return $this->attributes[$name] ?: $default;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be ??, right?

@fabpot fabpot force-pushed the passport-attributes branch from c7504a0 to 440ada3 Compare June 20, 2020 07:18
@fabpot fabpot mentioned this pull request Jun 20, 2020
Closed
@fabpot fabpot merged commit 3267e8e into symfony:master Jun 20, 2020
@fabpot fabpot deleted the passport-attributes branch June 20, 2020 15:04
@wouterj
Copy link
Member

wouterj commented Jun 20, 2020

Oh btw (I always forget that): should this be mentioned in the CHANGELOG?

@fabpot
Copy link
Member Author

fabpot commented Jun 21, 2020

Done in 9cff4e1

@wouterj wouterj mentioned this pull request Aug 25, 2020
Closed
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Feature Security Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@fabpot @wouterj @nicolas-grekas @chalasr @carsonbot