[FrameworkBundle] Allow to leverage autoconfiguration for DataCollectors with template #37332
+135
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16bf031 to
02e3138
Compare
fabpot
requested changes
Aug 11, 2020
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/ProfilerPass.php
Show resolved
Hide resolved
02e3138 to
1b65514
Compare
…ors with template
1b65514 to
986a0a2
Compare
|
Rebased and requested changes processed |
fabpot
approved these changes
Aug 13, 2020
|
Thank you @l-vo. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 22, 2020
…/autoconfigure (l-vo) This PR was merged into the master branch. Discussion ---------- Documentation about custom data collectors with autowire/autoconfigure Feature integrated in symfony/symfony#37332 Close #14060 Commits ------- 54eafd3 Documentation about custom data collectors with autowire/autoconfigure
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a datacollector with a template for the profiler display, an id must be set in the
data_collectortag and must be the same as this returned byDataCollectorInterface::getName. A template path can also be added to the tag. We lose in this case the ability to use autoconfigure. This PR suggests:data_collectortag. To follow the principle already used for services ids or events names, if not specified, the id is the data collector class name.data_collectortags still takes precedence over configuration from the code.This PR also provides an
AbstractDataCollectorto avoid to implement methods that might be considered as boilerplate:resetandgetName.