[Console] added TableCellStyle #37338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2bb8e3 to
1bf214a
Compare
fabpot
approved these changes
Aug 11, 2020
| $options = $this->getOptions(); | ||
|
|
||
| return isset($options['align']) | ||
| && self::DEFAULT_ALIGN !== $options['align']; |
|
|
||
| public function hasAlign(): bool | ||
| { | ||
| $options = $this->getOptions(); |
| return $this->options['style']; | ||
| } | ||
|
|
||
| public function hasAlign(): bool |
| && $style->hasAlign(); | ||
| } | ||
|
|
||
| public function hasCellFormat(): bool |
There was a problem hiding this comment.
I would remove this method as well
| { | ||
| $options = $this->getOptions(); | ||
|
|
||
| return isset($options['cellFormat']) && \is_string($options['cellFormat']); |
700c4ba to
dd70d46
Compare
|
@fabpot made edits |
fabpot
requested changes
Aug 16, 2020
| $rows[$line][$column] = new TableCell($lines[0], ['colspan' => $cell->getColspan()]); | ||
| $rows[$line][$column] = new TableCell( | ||
| $lines[0], ['colspan' => $cell->getColspan(), 'style' => $cell->getStyle()] | ||
| ); |
There was a problem hiding this comment.
Can you move it on one line again?
| $unmergedRows[$unmergedRowKey][$column] = new TableCell($value, ['colspan' => $cell->getColspan()]); | ||
| $unmergedRows[$unmergedRowKey][$column] = new TableCell( | ||
| $value, ['colspan' => $cell->getColspan(), 'style' => $cell->getStyle()] | ||
| ); |
There was a problem hiding this comment.
Can you move it on one line again?
| @@ -33,6 +34,10 @@ public function __construct(string $value = '', array $options = []) | |||
| throw new InvalidArgumentException(sprintf('The TableCell does not support the following options: \'%s\'.', implode('\', \'', $diff))); | |||
| } | |||
|
|
|||
| if (isset($options['style']) && !$options['style'] instanceof TableCellStyle) { | |||
| throw new InvalidArgumentException('The style option must be instance of TableCellStyle.'); | |||
| } | ||
|
|
||
| /** | ||
| * @return array|string[] |
There was a problem hiding this comment.
@return string[] should be enough, no?
|
@fabpot done |
fabpot
requested changes
Aug 16, 2020
| return isset($this->getOptions()['align']) && self::DEFAULT_ALIGN !== $this->getOptions()['align']; | ||
| } | ||
|
|
||
| public function hasCellFormat(): bool |
| return $this->getOptions()['cellFormat']; | ||
| } | ||
|
|
||
| public function hasAlign(): bool |
There was a problem hiding this comment.
I'm still not convinced that we should keep this method
There was a problem hiding this comment.
I think the both methods can be deleted. Updated
| } | ||
|
|
||
| /** | ||
| * @return array|string[] |
fabpot
approved these changes
Aug 16, 2020
0f1aaa5 to
6b13b9f
Compare
6b13b9f to
aff7628
Compare
|
Thank you @khoptynskyi. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 31, 2020
This PR was merged into the master branch. Discussion ---------- [Console] added TableCellStyle documentation See symfony/symfony#37338 Commits ------- 4a5be12 [Console] added TableCellStyle documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an opportunity to customize a table cell via TableCellStyle object.
It can be used as
See #13370