[Form] collect all transformation failures #37345
Conversation
xabbuh
commented
Jun 18, 2020
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #37262 |
| License | MIT |
| Doc PR |
b82ff49 to
a18a78d
Compare
| $this->assertCount(2, $form->getErrors()); | ||
| $this->assertSame('This value is not valid.', $form->getErrors()[0]->getMessage()); | ||
| $this->assertSame('This value is not valid.', $form->getErrors()[1]->getMessage()); |
There was a problem hiding this comment.
I wonder why this error is added twice.
There was a problem hiding this comment.
Once for the month and once for the year
There was a problem hiding this comment.
The removed continue is responsible for it. Maybe we should keep it?
There was a problem hiding this comment.
Hah, true. I didn't notice the invalid month. Was focused on the year only due to my initial test. 😄
There was a problem hiding this comment.
Should the cause of the error be tested as well then? To ensure one is really caused by the month and one by the year.
There was a problem hiding this comment.
3.4.40 also adds two errors in this case so it should be fine to keep that behavior.
There was a problem hiding this comment.
Should the cause of the error be tested as well then? To ensure one is really caused by the month and one by the year.
Yes, totally makes sense. I did that.
016b3d5 to
519ab16
Compare
|
Thank you @xabbuh. |