[Messenger] fixed queue_name option on amazon sqs connection #37364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2e5518 to
0a6ed8c
Compare
0a6ed8c to
df7e562
Compare
jderusse
reviewed
Jun 20, 2020
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Tests/Transport/ConnectionTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/Connection.php
Show resolved
Hide resolved
54d8124 to
f60068d
Compare
jderusse
approved these changes
Jun 20, 2020
chalasr
approved these changes
Jun 20, 2020
Nyholm
reviewed
Jun 20, 2020
| new Connection(['queue_name' => 'queue'], new SqsClient(['region' => 'eu-west-1', 'accessKeyId' => null, 'accessKeySecret' => null], null, $httpClient)), | ||
| Connection::fromDsn('sqs://default', ['queue_name' => 'queue'], $httpClient) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| $this->assertEquals( | |
| new Connection(['queue_name' => 'my_queue'], new SqsClient(['region' => 'eu-west-1', 'accessKeyId' => null, 'accessKeySecret' => null], null, $httpClient)), | |
| Connection::fromDsn('sqs://default/my_queue', ['queue_name' => 'queue_ignored'], $httpClient) | |
| ); | |
| } |
f60068d to
a6cb24d
Compare
|
Good catch, thanks @ck-developer. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.