[DI] deprecate Definition/Alias::setPrivate() #37373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4cde5d to
3623d9e
Compare
3623d9e to
95f1e66
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jun 22, 2020
This PR was merged into the 3.4 branch. Discussion ---------- Relax tests to unlock change on master | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Required to make #37373 green. Doesn't change any outcome. Commits ------- afe596e Relax tests to unlock change on master
95f1e66 to
1bea690
Compare
fabpot
approved these changes
Jun 22, 2020
chalasr
approved these changes
Jun 22, 2020
|
Thank you @nicolas-grekas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, there is a very subtle difference between
setPublic()andsetPrivate()that dates back to the FC/BC layer we created to turn services private by default.We kept this difference to help third party bundles provide support for a wide range of versions of Symfony, but since 5.2 will be released at the same time as 3.4 will enter EOM, we should remove this behavior and deprecate
setPrivate()to signal the change.This is what this PR does.