[Console] added info method to symfony style #37415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfelbox
reviewed
Jun 25, 2020
| @@ -163,6 +163,14 @@ public function note($message) | |||
| $this->block($message, 'NOTE', 'fg=yellow', ' ! '); | |||
| } | |||
|
|
|||
| /** | |||
| * {@inheritdoc} | |||
There was a problem hiding this comment.
there's no "info" method on StyleInterface
if we want to add one, this should be done in a BC manner, aka via an @method annotation
There was a problem hiding this comment.
@nicolas-grekas I updated the docblock. I took the same approach that we did for the method comment (it is not part of the interface). What do you reckon?
nicolas-grekas
approved these changes
Jun 28, 2020
|
Thank you @titomiguelcosta. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to have an info method as part of the SymfonyStyle class. This would prevent having to use the <INFO> tag, and it is consistent with other methods like warning and error (similar to the types available in monolog)