Skip to content

[PhpUnitBridge] Fix compatibility with phpunit 9.3 #37418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2020
Merged

[PhpUnitBridge] Fix compatibility with phpunit 9.3 #37418

merged 1 commit into from
Jun 28, 2020

Conversation

gennadigennadigennadi
Copy link
Contributor

@gennadigennadigennadi gennadigennadigennadi commented Jun 25, 2020 •
edited
Loading

Q A
Branch? master for features / 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

In PHPUnit 9.3 some Classes were moved or renamed, to make the PhpunitBridge compatible with PhpUnit 9.3 it necessary to call the new Loader instead of the Registry.

@gennadigennadigennadi gennadigennadigennadi mentioned this pull request Jun 25, 2020
Closed
@gennadigennadigennadi
Copy link
Contributor Author

I am not 100% sure if adding 9_3 is right or if it would be enough to just edit CommandForV9.
I am looking forward to your feedback.

@nicolas-grekas nicolas-grekas changed the title Fix: compatibility with phpunit 9.3 [PhpUnitBridge] Fix compatibility with phpunit 9.3 Jun 28, 2020
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Jun 28, 2020
@nicolas-grekas
Copy link
Member

I am not 100% sure if adding 9_3 is right or if it would be enough to just edit CommandForV9.

I think editing the existing class would be good enough:
use PHPUnit\TextUI\Configuration\Configuration as LegacyConfiguration; + a class_exists() check for the new class should be OK.

@gennadigennadigennadi gennadigennadigennadi force-pushed the fix/compatibility-with-phpunit-93 branch from 3f457d5 to 871c704 Compare June 28, 2020 15:08
@nicolas-grekas nicolas-grekas force-pushed the fix/compatibility-with-phpunit-93 branch from 871c704 to de71a12 Compare June 28, 2020 15:12
@nicolas-grekas
Copy link
Member

Thank you @gennadigennadigennadi.

@nicolas-grekas nicolas-grekas merged commit 9709500 into symfony:4.4 Jun 28, 2020
This was referenced Jul 24, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@gennadigennadigennadi @nicolas-grekas @carsonbot