[HttpClient] add StreamableInterface to ease turning responses into PHP streams #37443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jun 28, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | - |
| Tickets | - |
| License | MIT |
| Doc PR | - |
a670de1 to
de103b3
Compare
derrabus
approved these changes
Jun 28, 2020
stof
reviewed
Jul 6, 2020
| @@ -95,7 +95,7 @@ public function toStream(bool $throw = true) | |||
| } | |||
|
|
|||
| $handle = function () { | |||
| $stream = StreamWrapper::createResource($this->response); | |||
| $stream = $this->response instanceof StreamableInterface ? $this->response->toStream(false) : StreamWrapper::createResource($this->response); | |||
There was a problem hiding this comment.
wouldn't this bypass changes done by the passthru callable ?
There was a problem hiding this comment.
nope: this only extracts any potential handle for stream_select(), but the stream is always read through the resource created L103 below, which goes through the AsyncResponse
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.