[Process] Fix Permission Denied error when writing sf_proc_00 lock files on Windows #37461
Conversation
|
Thank you @JasonStephensTAMU. |
|
@nicolas-grekas Thanks, and I apologize for the lack of communication over the weekend, It was Independence day weekend in the states. To answer your question in the review: I began working on some code that implemented your suggestion, I hadn't yet settled on the actions to take if/when unlinking the lock file succeeds. With the current changes, does the test I attempted the same change, and after seeing the failed test I worked towards the changes that were initially submitted in the PR, though it may just be my machine. |
|
@JasonStephensTAMU no worries. Not sure what you about |
|
@nicolas-grekas Ah, must be just on my machine. All good, carry on! |
Passes current Process unit tests.
On Windows systems, a new set of sf_proc_## files are generated in the system temp directory for each WindowsPipes object. These files are removed when the WindowsPipes object is destroyed.
This avoids receiving a permission denied error when attempting to write to sf_proc_## files between multiple sites running as different users, when the users do not have permissions to modify each others files.
Changes