[Messenger] add redeliveredAt in RedeliveryStamp construct #37480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failed because of weird |
|
Can you please add a test case? This will allow spotting a typo ;) |
|
Nicely catch @nicolas-grekas |
maxhelias
approved these changes
Jul 7, 2020
Tobion
suggested changes
Jul 11, 2020
| @@ -24,12 +24,12 @@ final class RedeliveryStamp implements StampInterface | |||
| private $exceptionMessage; | |||
| private $flattenException; | |||
|
|
|||
| public function __construct(int $retryCount, string $exceptionMessage = null, FlattenException $flattenException = null) | |||
| public function __construct(int $retryCount, string $exceptionMessage = null, FlattenException $flattenException = null, \DateTimeImmutable $redeliveredAt = null) | |||
There was a problem hiding this comment.
this should typehint DateTimeInterface since this is what getRedeliveredAt also typehints
fabpot
approved these changes
Aug 2, 2020
|
Thank you @qkdreyer. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this would allows one to correctly unserialize a RedeliveryStamp with a custom serializer not using the php serialize function