Skip to content

[Worfklow] Add 'initiated' event which is dispatched upon entering inital place #37481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

pluk77
Copy link
Contributor

@pluk77 pluk77 commented Jul 2, 2020

Q A
Branch? Master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #37421
License MIT
Doc PR symfony/symfony-docs#

Added new INITIATED event which is dispatched upon initiating a new subject with the initial place as currently the place name is missing from the entered even when the subject is marked with its initial marking.

@pluk77 pluk77 marked this pull request as ready for review July 2, 2020 14:02
@pluk77 pluk77 requested a review from lyrixx as a code owner July 2, 2020 14:02
@lyrixx
Copy link
Member

lyrixx commented Jul 3, 2020

Note for reviewer: do not comment here for now. I commented on the related issue

@lyrixx lyrixx added the Workflow label Jul 3, 2020
@nicolas-grekas
Copy link
Member

Could you please update the title of the PR so that we can read what it is about?
Some advice: use the prefix [Worfklow] and don't put any issue number in the PR.
The PR title should read as a line in the changelog.
Thanks.

@nicolas-grekas nicolas-grekas added this to the next milestone Jul 3, 2020
@pluk77 pluk77 changed the title Pluk77 patch workflow 37421 [Worfklow] Add 'initiated' event which is dispatched upon entering inital place Jul 3, 2020
@lyrixx
Copy link
Member

lyrixx commented Aug 12, 2020

Closing in favor of #37539

@lyrixx lyrixx closed this Aug 12, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow initial_marking is optional and entered event on initial_marking is not dispatched
4 participants