[PhpUnitBridge] ExcludeList usage for PHPUnit 9.4 #37513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fe8f2b to
aa2088f
Compare
|
Great thanks. Can you please target branch 3.4? |
|
The fix (CommandForV9) for PHPUnit 9 is missing inside the 3.4 Branch, I have not checked if 3.4 is capable of running PHPUnit 9. Are the fixes for PHPUnit 9 not required in Symfony 3.4? At least I have not not seen them inside the 3.4 Branch. |
Oh, OK for 4.4 then! |
| @@ -254,7 +254,11 @@ | |||
| if (!class_exists('SymfonyBlacklistPhpunit', false)) { | |||
| class SymfonyBlacklistPhpunit {} | |||
There was a problem hiding this comment.
can you rename this class also please?
SymfonyExcludeListPhpunit
aa2088f to
f59915d
Compare
|
Thank you @gennadigennadigennadi. |
This was referenced Jul 24, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: ExcludeList usage for PHPUnit >= 9.3