-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
feature #37002 [Amqp] Add amqps support #37518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vasilvestre Is it still a draft? |
Yeah totally, I had no time to work on it and I'm definitly not sure I'm on the good way. I do not really know the AMQP protocol that well and I do not even talk about AMQPS.. Anyone could open another PR or continue this one. |
Thanks for the fast reply. I'm going to close then as we don't keep draft PR around. If someone wants to take over, it will still be referenced in the ticket. |
Out of this, which direction should this PR take? Cases (to cover)Case 1 (simple): Case 2 (complex): Questions (I have to anyone able to answer that !)
Here's my opinion on this so far, I've decided to use default value for SSL if nothing is passed, the first goal is to cover the case 1 (the most simple). ObservationsI think this PR should aim on :
|
Are there any plans on backporting the changes done here: #38007 to Symfony 4.4? Is that something I can create a PR for if no-one is currently planning on doing so? 4.4 still has a relatively long life ahead of it, and there's currently no way of getting AMQPS working as far as I can tell. Happy to take this on, seems perfectly transferable to the existing classes? |
AFAIK, no backport is supported in Symfony. But as the classes aren't final, you can override them and use your own implementation that supports AMQPS IMO |
Actually ttl parameter seem to be used to initialize amqp secured exception, but DSN seems to do not support amqps alone. Would like to add ca_cert cert and pem files parameter through dsn.