Skip to content

[Messenger] Allow same middleware to be used multiple times with different arguments #37569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

[Messenger] Allow same middleware to be used multiple times with different arguments #37569

merged 1 commit into from
Jul 23, 2020

Conversation

HypeMC
Copy link
Member

@HypeMC HypeMC commented Jul 14, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #37568
License MIT
Doc PR -

Middleware service names now take into account arguments as well to allow the same middleware to be used multiple times with different arguments:

framework:
    messenger:
        buses:
            messenger.bus.default:
                middleware:
                    - doctrine_ping_connection: ['main']
                    - doctrine_ping_connection: ['logs']

@HypeMC HypeMC requested a review from sroze as a code owner July 14, 2020 06:29
@HypeMC HypeMC changed the base branch from master to 4.4 July 14, 2020 06:29
@HypeMC HypeMC changed the title Allow same middleware to be used multiple times with different arguments [Messenger] Allow same middleware to be used multiple times with different arguments Jul 14, 2020
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Jul 22, 2020
@nicolas-grekas
Copy link
Member

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit 0d867bc into symfony:4.4 Jul 23, 2020
@HypeMC HypeMC deleted the messenger-pass-middleware-fix branch July 23, 2020 09:59
This was referenced Jul 24, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

@sroze sroze Awaiting requested review from sroze

+1 more reviewer

@ogizanagi ogizanagi ogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Problem with defining Doctrine middleware for different connections in Messenger
5 participants
@HypeMC @nicolas-grekas @ogizanagi @chalasr @carsonbot