[Mime] Keep Sender full address when used by non-SMTP transports #37580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
approved these changes
Jul 15, 2020
|
@dmaicher But tests are failing on deps=high, which is expected, right? |
|
@fabpot ah of course. So they should pass once this fix has been merged up I guess? 😊 |
This was referenced Jul 24, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #36178
The
Envelopeis an SMTP concept. The Sender is used in theMAIL FROMSMTP command, where only an address is supported. But we are also supporting non-SMTP transports, where the Sender might also be used as theFromheader, where a full mailbox is supported.To take into account the 2 usages, this PR keeps the full mailbox in the Envelope and let the SMTP class only use the address (which was already the case anyway).