Allows RedisClusterProxy instance in Lock RedisStore #37590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
commented
Jul 15, 2020
|
failing Travis test is related to branch 3.4 (when Redis server is not running) |
nicolas-grekas
approved these changes
Jul 22, 2020
stof
reviewed
Jul 22, 2020
|
Are the failures related? Can you rebase to retrigger maybe? |
rebased. Faillure are not related. failure is about test against branch 3.4 without Redis container running nor mechanism to early exit when redis is not runing |
|
CI green @nicolas-grekas |
|
Thank you @jderusse. |
This was referenced Jul 24, 2020
Merged
Merged
Merged
b1rdex
reviewed
Jul 27, 2020
| @@ -33,13 +33,13 @@ class RedisStore implements StoreInterface | |||
| private $initialTtl; | |||
|
|
|||
| /** | |||
| * @param \Redis|\RedisArray|\RedisCluster|\Predis\ClientInterface $redisClient | |||
| * @param float $initialTtl the expiration delay of locks in seconds | |||
| * @param \Redis|\RedisArray|\RedisCluster|RedisProxy|RedisClusterProxy\Predis\ClientInterface $redisClient | |||
There was a problem hiding this comment.
@jderusse There is a bug: no pipe in RedisClusterProxy\Predis\ClientInterface leads to wrong class FQN.
b1rdex
added a commit
to b1rdex/symfony
that referenced
this pull request
Jul 27, 2020
This is a fix for a regression from symfony#37590
b1rdex
added a commit
to b1rdex/symfony
that referenced
this pull request
Jul 27, 2020
This is a fix for a regression from symfony#37590
stof
added a commit
that referenced
this pull request
Jul 27, 2020
This PR was merged into the 4.4 branch. Discussion ---------- Fix RedisStore constructor signature | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | no | License | MIT | Doc PR | no This is a fix for a regression from #37590 Commits ------- 6831271 Fix RedisStore constructor signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow clients instance of RedisClusterProxy created by the StoreFactory in #28691 /cc @nicolas-grekas