Fix checks for phpunit releases on Composer 2 #37607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea847f6 to
f64114e
Compare
|
Related: composer/composer#9054. |
GrahamCampbell
approved these changes
Jul 19, 2020
fabpot
approved these changes
Jul 20, 2020
f64114e to
2bb3f08
Compare
|
Thank you @colinodell. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 23, 2020
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- Require PHPUnit 9.3 on PHP 8 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT The first version of PHPUnit to support PHP 8.0 is PHPUnit 9.3. --- Depends on #37607. Related to composer/composer#9054. Commits ------- 54b13c0 Require PHPUnit 9.3 on PHP 8
This was referenced Jul 24, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple-phpunithas a core assumption that any version of PHPUnit without a stable release will only have one dev version returned by Composer. Per #37601, it's possible for Composer 2 to list more than one dev version. This breaks that assumption and therefore prevents the installation of 9.3.* (which is needed for testing on PHP 8).The fix implemented here is to remove any versions containing
dev-or-devfrom the list of possible versions to see if any stable versions remain.