[Locale] use the correct way for Intl error #3765
Conversation
|
@eriksencosta, @igorw: Can you give me your thoughts? |
|
@fabpot This seems right, I'll need to check it at home but I saw that the tests passed in PHP 5.3.2 in @stealth35 Travis builds. @igorw we need to talk to find a better way to manage the Locale maintenance. Things like this are becoming a nightmare with some of the intl updates. We need to specify a cycle to update the ICU data too and see how this can affect our tests (a lot changed since the last update that I made in April 2011). Are you interested? |
|
see #3528 for a PR on ICU data update. |
|
@fabpot Any info why this is not merged yet ? |
|
I'm just waiting for an ack from @eriksencosta or @igorw |
|
it also needs to be rebased |
|
I'm cherry-picking it to 2.0 it now and will push a new PR. |
|
@fabpot @stof @stealth35 Please, see #3765. |
|
Closing in favor of #3765 |
Commits ------- b1ea552 [Locale] micro-optimization 663d218 [Locale] changed method name bb61e09 [Locale] use the correct way for Intl error Discussion ---------- [2.0][Locale] rebased PR 3765 plus few changes Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - #3765 was right but was made in master. Cherry-picked and rebased for 2.0. Tests are passing.
All Stub* should filled the intl_get_*
An ICU error code may have differents messages and it's a failure only when it > 0 (a negative code is just a warning)
I think this PR should be more simple, (cause all sucess method should return a
U_ZERO_ERROR) so I need your feedbackAfter this I'll make a PR for the
StubResourceBundle✌️