-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Stopwatch] Add name property to the stopwatchEvent #37676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stopwatch] Add name property to the stopwatchEvent #37676
Conversation
AhmedRaafat14
commented
Jul 27, 2020
•
edited
Loading
edited
Q | A |
---|---|
Branch? | master for features |
Bug fix? | no |
New feature? | yes |
Deprecations? | no |
Tickets | Fix #37627 |
License | MIT |
Doc PR | symfony/symfony-docs#... |
0ae375f
to
928ab32
Compare
eae3f3e
to
9fd5a98
Compare
aa65889
to
965ef17
Compare
f255933
to
7eccd04
Compare
e1a2110
to
b224451
Compare
@AhmedRaafat14 I've just spent some time with the code and I've changed (again) my mind, sorry about this. Let's keep your first commit and use the output I suggested in #37676 (comment) |
Yes, sure thing thanks for pointing out that. |
d7d1796
to
f441078
Compare
@fabpot Reverted back and will update the docs PR again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase the PR to get rid of the merge commit?
1e3b7ec
to
393bc32
Compare
f5650a4
to
f2b64ec
Compare
Thank you @AhmedRaafat14. |
…nt (simivar) This PR was submitted for the 5.x branch but it was squashed and merged into the 5.2 branch instead. Discussion ---------- [Stopwatch] Document new "name" property of StopwatchEvent | Q | A | ------------- | --- | Branch? | 5.x <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | #37676 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry --> In Pull Request #37676 a new property was added to the `StopwatchEvent` which was not documented in `CHANGELOG.md` file Commits ------- de43e36 [Stopwatch] Document new "name" property of StopwatchEvent