Skip to content

[Routing] Allow inline definition of requirements and defaults for host #37696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

[Routing] Allow inline definition of requirements and defaults for host #37696

merged 1 commit into from
Jul 30, 2020

Conversation

julienfalque
Copy link
Contributor

@julienfalque julienfalque commented Jul 29, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR symfony/symfony-docs#14007

This PR extends the support of inline routing requirements and defaults to the host part, which can also contain parameters.

@julienfalque julienfalque force-pushed the routing-host-inline branch from d16f71b to e2cae06 Compare July 29, 2020 11:37
@julienfalque julienfalque marked this pull request as ready for review July 29, 2020 11:42
@nicolas-grekas nicolas-grekas added this to the next milestone Jul 29, 2020
nicolas-grekas
nicolas-grekas approved these changes Jul 29, 2020
View reviewed changes
@julienfalque julienfalque force-pushed the routing-host-inline branch from e2cae06 to 1501476 Compare July 29, 2020 16:19
@julienfalque julienfalque mentioned this pull request Jul 29, 2020
Closed
@fabpot
Copy link
Member

fabpot commented Jul 30, 2020

Thank you @julienfalque.

@fabpot fabpot merged commit e411c96 into symfony:master Jul 30, 2020
@julienfalque
Copy link
Contributor Author

Thank you @fabpot @nicolas-grekas :)

@julienfalque julienfalque deleted the routing-host-inline branch July 30, 2020 08:55
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
@julienfalque julienfalque mentioned this pull request Dec 7, 2020
Merged
wouterj added a commit to symfony/symfony-docs that referenced this pull request Dec 9, 2020
@wouterj
feature #14671 Document routing inline requirements and defaults for …
d43d930 
…host (julienfalque)

This PR was merged into the 5.2 branch.

Discussion
----------

Document routing inline requirements and defaults for host

Relates to symfony/symfony#37696.

Commits
-------

8c21f36 Document routing inline requirements and defaults for host
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Routing Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@julienfalque @fabpot @nicolas-grekas @carsonbot