Skip to content

[Validator] Debug validator command #37706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2020
Merged

[Validator] Debug validator command #37706

merged 2 commits into from
Sep 5, 2020

Conversation

loic425
Copy link
Contributor

@loic425 loic425 commented Jul 29, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#...

help

CustomerAddress

Customer

@loic425 loic425 force-pushed the feature/debug-validator-command branch 4 times, most recently from 9687b0e to f281244 Compare July 30, 2020 07:43
@nicolas-grekas nicolas-grekas added this to the next milestone Jul 30, 2020
noniagriconomie
noniagriconomie reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@noniagriconomie noniagriconomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice add :)
small review passing by

@loic425 loic425 force-pushed the feature/debug-validator-command branch 2 times, most recently from 630ac4f to 5a5236e Compare July 31, 2020 15:10
ogizanagi
ogizanagi reviewed Aug 12, 2020
View reviewed changes
Copy link
Contributor

@ogizanagi ogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, I think it's a really nice addition ✨

@loic425 loic425 force-pushed the feature/debug-validator-command branch from 07522f9 to 8581aa2 Compare August 26, 2020 13:12
fabpot
fabpot requested changes Sep 4, 2020
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix tests with low deps. In the FrameworkBundle composer.json file, you need to require symfony/validator ^5.2.

src/Symfony/Component/Validator/Command/DebugCommand.php Outdated
}
}

if (empty($rows)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!$rows) {

@loic425
Copy link
Contributor Author

loic425 commented Sep 4, 2020

You need to fix tests with low deps. In the FrameworkBundle composer.json file, you need to require symfony/validator ^5.2.

@fabpot It seems to be not enough.
https://travis-ci.org/github/symfony/symfony/jobs/724055904#L6907

@fabpot fabpot force-pushed the feature/debug-validator-command branch 2 times, most recently from 42e2753 to 5847037 Compare September 5, 2020 14:25
@fabpot fabpot force-pushed the feature/debug-validator-command branch from 5847037 to 6ec54c7 Compare September 5, 2020 14:41
@fabpot
Copy link
Member

fabpot commented Sep 5, 2020

Thank you @loic425.

@fabpot fabpot mentioned this pull request Sep 5, 2020
Closed
@fabpot fabpot merged commit 4ab612c into symfony:master Sep 5, 2020
@loic425 loic425 deleted the feature/debug-validator-command branch September 5, 2020 16:38
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogizanagi ogizanagi ogizanagi left review comments

@noniagriconomie noniagriconomie noniagriconomie left review comments

@fabpot fabpot fabpot requested changes

Assignees
No one assigned
Labels
Feature Status: Needs Work Validator
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
6 participants
@loic425 @fabpot @ogizanagi @noniagriconomie @nicolas-grekas @carsonbot