[Messenger] - Add option to confirm message delivery in Amqp connection #37759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
suggested changes
Aug 7, 2020
src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php
Outdated
Show resolved
Hide resolved
apfelbox
reviewed
Aug 7, 2020
src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php
Outdated
Show resolved
Hide resolved
6fcb8cd to
b542b7f
Compare
nicolas-grekas
approved these changes
Aug 31, 2020
| @@ -6,3 +6,4 @@ CHANGELOG | |||
|
|
|||
| * Introduced the AMQP bridge. | |||
| * Deprecated use of invalid options | |||
| * Add option to confirm message delivery | |||
There was a problem hiding this comment.
can you please move this to a new 5.2 section?
src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php
Outdated
Show resolved
Hide resolved
b542b7f to
7b40ff9
Compare
7b40ff9 to
5682d76
Compare
fabpot
approved these changes
Sep 12, 2020
|
Thank you @scyzoryck. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! My first PR here.
Sometimes we need to be sure that messages are delivered to Amqp. To make it work we need to wait for the confirmation from the Amqp server. So let's wait for it confirmation if confirmation timeout is defined. Default behaviour are not modified - waiting for confirmation will impact performance of sending message.