[ClassLoader][Routing] Fix namespace parsing on php 8 #37783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa01dde to
3d293b2
Compare
fabpot
approved these changes
Aug 10, 2020
|
Thank you @derrabus. |
stof
reviewed
Aug 10, 2020
| @@ -216,6 +216,11 @@ public static function fixNamespaceDeclarations($source) | |||
| $inNamespace = false; | |||
| $tokens = token_get_all($source); | |||
|
|
|||
| $nsTokens = [T_WHITESPACE => true, T_NS_SEPARATOR => true, T_STRING => true]; | |||
| if (\defined('T_NAME_QUALIFIED')) { | |||
| $nsTokens[T_NAME_QUALIFIED] = true; | |||
There was a problem hiding this comment.
This also misses T_NAME_FULLY_QUALIFIED
There was a problem hiding this comment.
Can you give an example that would result in \T_NAME_FULLY_QUALIFIED being emitted here?
weaverryan
added a commit
to SymfonyCasts/symfony5
that referenced
this pull request
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way namespace declarations are parsed has changed in php 8 (see php/php-src#5827). This PR should fix the corresponding issues in the ClassLoader and Routing components.
Note that Doctrine Annotations suffers from the same issue (doctrine/annotations#339). I had to run the Routing tests locally with doctrine/annotations#344 applied.