Skip to content

PHPUnit's assertContains() performs strict comparisons #37784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Aug 9, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Part of #37564
License MIT
Doc PR N/A

In PHPUnit 9.3, assertContains() performs a strict comparison which causes a few test failures in our test suite. This PR should fix them.

@fabpot
Copy link
Member

fabpot commented Aug 10, 2020

Thank you @derrabus.

@fabpot fabpot merged commit 4ace472 into symfony:3.4 Aug 10, 2020
@derrabus derrabus deleted the bugfix/strict-assert-contains branch August 10, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants