[Workflow] Choose which Workflow events should be dispatched #37815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Aug 12, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #36633 ; Fix #36617 |
| License | MIT |
| Doc PR |
2 tasks
8e9fdde to
458d12e
Compare
fabpot
requested changes
Aug 13, 2020
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
458d12e to
8375f23
Compare
8375f23 to
914d36c
Compare
|
@fabpot thanks for the review. I have addressed your comments |
c739bea to
1112937
Compare
fabpot
reviewed
Aug 13, 2020
src/Symfony/Bundle/FrameworkBundle/Resources/config/workflow.php
Outdated
Show resolved
Hide resolved
fabpot
reviewed
Aug 13, 2020
1112937 to
160c660
Compare
160c660 to
cfc53ad
Compare
fabpot
approved these changes
Aug 13, 2020
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Aug 13, 2020
This PR was merged into the 5.2-dev branch. Discussion ---------- [Workflow] Improve and fix | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #37815 review | License | MIT | Doc PR | # Hi @lyrixx thx for such fast PR take over :) while reviewing i found this typo i think also i reordered the constants inside the events class to map with the order of fireing event Commits ------- 9bbce41 [Workflow] Improve and fix
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Aug 13, 2020
This PR was merged into the 5.2-dev branch. Discussion ---------- [Workflow] Improve and fix | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix symfony/symfony#37815 review | License | MIT | Doc PR | # Hi @lyrixx thx for such fast PR take over :) while reviewing i found this typo i think also i reordered the constants inside the events class to map with the order of fireing event Commits ------- 9bbce417ff [Workflow] Improve and fix
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.