Skip to content

[Messenger] Don't require doctrine/persistence when installing symfony/messenger #37823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2020
Merged

[Messenger] Don't require doctrine/persistence when installing symfony/messenger #37823

merged 1 commit into from
Aug 13, 2020

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Aug 13, 2020

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #36790
License MIT
Doc PR N/A

As of today, installing symfony/messenger installs symfony/doctrine-messenger as well. Which means adding doctrine/persistence as a hard dep of the latest will install it for any user requiring symfony/messenger in 5.2.

I think it should stay a soft-dependency until we remove symfony/doctrine-messenger as a symfony/messenger dependency as of Symfony 6.0 (as mentioned in #35422).


related: #36785

@fabpot
Copy link
Member

fabpot commented Aug 13, 2020

Thank you @ogizanagi.

@fabpot fabpot merged commit ae677cc into symfony:master Aug 13, 2020
@ogizanagi ogizanagi deleted the rm-messenger-doctrine-dep branch August 13, 2020 15:00
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants