[Messenger] Add message timestamp to amqp connection #37867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
suggested changes
Aug 17, 2020
src/Symfony/Component/Messenger/Bridge/Amqp/Tests/Transport/ConnectionTest.php
Show resolved
Hide resolved
f4be339 to
53cb6a8
Compare
fabpot
requested changes
Aug 18, 2020
| @@ -266,7 +267,7 @@ public function testItSetupsTheConnectionWithDefaults() | |||
| ); | |||
|
|
|||
| $amqpExchange->expects($this->once())->method('declareExchange'); | |||
| $amqpExchange->expects($this->once())->method('publish')->with('body', null, AMQP_NOPARAM, ['headers' => [], 'delivery_mode' => 2]); | |||
| $amqpExchange->expects($this->once())->method('publish')->with('body', null, AMQP_NOPARAM, ['headers' => [], 'delivery_mode' => 2, 'timestamp' => ClockMock::time()]); | |||
There was a problem hiding this comment.
Instead of using ClockMock directly, you should use a @group time-sensitive annotation on the test class itself.
53cb6a8 to
9c3989b
Compare
9c3989b to
281540e
Compare
fabpot
approved these changes
Aug 18, 2020
|
Thank you @bzajacc. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default timestamp to amqp transport message.
It is useful when you logging each message, and your consumer is down, you alway get right message time when start consume again.