Skip to content

[Notifier] backport documentation changes #37922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2020
Merged

[Notifier] backport documentation changes #37922

merged 1 commit into from
Aug 23, 2020

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 23, 2020

Q A
Branch? 5.1
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

I think #37809 should have been merged into the 5.1 branch.

@xabbuh xabbuh added this to the 5.1 milestone Aug 23, 2020
@fabpot
Copy link
Member

fabpot commented Aug 23, 2020

It could have been, but we started to document DSNs in 5.2, so let's be consistent.

@fabpot fabpot closed this Aug 23, 2020
@xabbuh
Copy link
Member Author

xabbuh commented Aug 23, 2020

Are you sure? I compared all Notifier readme files between master and 5.1 and this was the only change.

@fabpot fabpot reopened this Aug 23, 2020
@fabpot
Copy link
Member

fabpot commented Aug 23, 2020

Thank you @xabbuh.

@fabpot fabpot merged commit 32ca714 into symfony:5.1 Aug 23, 2020
@xabbuh xabbuh deleted the pr-37809 branch August 23, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Notifier Status: Needs Review
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @fabpot @carsonbot @noniagriconomie