[Serializer] fixed fix encoding of cache keys with anonymous classes #37937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michaelzangerle
commented
Aug 25, 2020
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #36589 |
| License | MIT |
| Doc PR | - |
b855681 to
11fd0ef
Compare
src/Symfony/Component/Serializer/Mapping/Factory/CacheClassMetadataFactory.php
Outdated
Show resolved
Hide resolved
|
Adjusted test case in the framework bundle to match new cache key escaping. Tests for serializer and framework bundle run through locally and in AppVeyor but fail on Travis for some reason. One error on travis is probably related to the change but I can't reproduce it locally as it should be fixed with the change. The other is a redis error according to the error message. Any advice? |
src/Symfony/Component/Serializer/Mapping/Factory/CacheClassMetadataFactory.php
Outdated
Show resolved
Hide resolved
df84340 to
3a46753
Compare
|
Thank you @michaelzangerle. |
hultberg
pushed a commit
to hultberg/symfony
that referenced
this pull request
Sep 17, 2021
…anonymous classes (michaelzangerle) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Serializer] fixed fix encoding of cache keys with anonymous classes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony#36589 | License | MIT | Doc PR | - Commits ------- 3a46753 [Serializer] fixed fix encoding of cache keys with anonymous classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.