[TwigBridge] allow null for $message of filter method trans
#37941
Conversation
|
Closing as explained in the issue. |
Have you even read the issue in full, @fabpot? Sorry, I don't mean to be rude, but I can't understand how you can just close this without even considering. |
|
Reopening |
|
Can you please rebase and target 5.1 also? |
|
Will do. Thank you for your consideration. |
trans did not allow null values for $message parameter anymoretrans
transtrans
@nicolas-grekas, the source branch cannot be changed for a pull request. I can rebase 5.0 onto 5.1 but the source branch will still read 5.0 which might lead to confusions. What should I do in your opinion? Should we stick to the name 5.0 for the source branch or should I replace the pull request with a new one having target/base branch and source branch both set to 5.1? The Symfony guidelines on how to create pull requests say that "bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.)" That's why I have chosen 5.0 in the first place. Just as a remark. I'm sorry if that was wrong. |
|
You can rebase your branch 5.0 on 5.1 yes, that'd be fine on our side. You could then delete it on your fork, 5.0 is not maintained anymore anyway. |
Done. fabbot.io still has comlaints about "Common Typos" and "Merge Commits" which don't seem to have any relations to my changes/commits however. |
|
Looks like you forgot to rebase your changes on 5.1 (many unrelated commits). When done, push it again, that should be enough. |
… allow null values for `$message` parameter anymore
|
Thank you @Flinsch. |
I can only return my thanks, @nicolas-grekas. |
With Symfony 5.0, filter method
transof Symfony Twig Bridge does not allow null values for$messageparameter anymore, breaking backward compatibility. See also #37931. The included commit provides a fix to this BC break by allowing null values again.