[Security] Renamed provider key to firewall name #37942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Aug 25, 2020
src/Symfony/Component/Security/Core/Authentication/Token/PreAuthenticatedToken.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Token/PreAuthenticatedToken.php
Outdated
Show resolved
Hide resolved
e859eea to
5bee51e
Compare
fabpot
requested changes
Aug 26, 2020
src/Symfony/Component/Security/Http/Authentication/DefaultAuthenticationSuccessHandler.php
Show resolved
Hide resolved
5bee51e to
169fff9
Compare
|
@wouterj I think you forgot to add notes in the main UPGRADE files for 5.2 and 6.0. |
fabpot
approved these changes
Aug 26, 2020
|
And you also have some failing tests. |
169fff9 to
d336a8d
Compare
d336a8d to
91b2763
Compare
fabpot
approved these changes
Aug 26, 2020
|
Thank you @wouterj. |
5 tasks
Merged
chalasr
added a commit
to lexik/LexikJWTAuthenticationBundle
that referenced
this pull request
Nov 14, 2020
This PR was squashed before being merged into the 2.x-dev branch. Discussion ---------- Fix Symfony 5.2 getProviderKey deprecation 👋 Hi > Since symfony/security-http 5.2: Method "Lexik\Bundle\JWTAuthenticationBundle\Security\Authentication\Token\JWTUserToken::getProviderKey()" has been deprecated, rename it to "getFirewallName()" instead. from symfony/symfony#37942 Commits ------- 50959e7 Fix Symfony 5.2 getProviderKey deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
$providerKeyargument names on the classes that will remain in use, even when the new Security system will take over. @fabpot do you think these changes are worth it?Officially, all token classes are not marked as
@final. Do I need to take into account when someone is overriding thegetProviderKey()method? Also, I couldn't find a way to trigger a deprecation notice for deprecated properties, is this a problem?