Skip to content

[PhpunitBridge] Fix deprecation type detection (when several autoload files are used) #37959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2020
Merged

[PhpunitBridge] Fix deprecation type detection (when several autoload files are used) #37959

merged 1 commit into from
Sep 2, 2020

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Aug 26, 2020 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Several autoload files are supported by the PHPUnit Bridge but when the internal paths are registered (for deprecation type detection), the paths (from prefixes) of the last autoload file override the paths previously registered. This PR fixes this bug.

@l-vo l-vo force-pushed the fix_type_detection_with_multiple_vendor_dirs branch 6 times, most recently from 4c739ce to 223e847 Compare August 26, 2020 21:28
@l-vo
Copy link
Contributor Author

l-vo commented Aug 27, 2020

status: needs work

@l-vo l-vo changed the title [PhpunitBridge] Fix deprecation type detection (when several autoload files are used) [WIP][PhpunitBridge] Fix deprecation type detection (when several autoload files are used) Aug 27, 2020
@l-vo l-vo force-pushed the fix_type_detection_with_multiple_vendor_dirs branch 4 times, most recently from 11ca181 to 1fa3818 Compare August 28, 2020 20:06
@l-vo l-vo changed the title [WIP][PhpunitBridge] Fix deprecation type detection (when several autoload files are used) [PhpunitBridge] Fix deprecation type detection (when several autoload files are used) Aug 28, 2020
@l-vo
Copy link
Contributor Author

l-vo commented Aug 28, 2020

status: needs review

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Aug 31, 2020
@l-vo
[PhpunitBridge] Fix deprecation type detection
cc7b6c5 
When using several vendor directories
@l-vo l-vo force-pushed the fix_type_detection_with_multiple_vendor_dirs branch from 1fa3818 to cc7b6c5 Compare August 31, 2020 19:11
@fabpot
Copy link
Member

fabpot commented Sep 2, 2020

Thank you @l-vo.

@fabpot fabpot merged commit 52719f2 into symfony:4.4 Sep 2, 2020
@xabbuh xabbuh mentioned this pull request Sep 3, 2020
Merged
This was referenced Sep 27, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug PhpUnitBridge Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@l-vo @fabpot @nicolas-grekas @carsonbot