Skip to content

[Workflow] Expose the Metadata Store in the DIC #37979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2020

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Aug 28, 2020

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #37955
License MIT
Doc PR

I did not updated the CHANGELOG, because IMHO it not worth it

@@ -742,6 +742,7 @@ private function registerWorkflowConfiguration(array $config, ContainerBuilder $
}
}
$metadataStoreDefinition->replaceArgument(2, $transitionsMetadataDefinition);
$container->setDefinition(sprintf('%s.metadata_store', $workflowId), $metadataStoreDefinition);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally understood what you meant ^^

Is it possible to expose it as type + named parameter ?

@fabpot
Copy link
Member

fabpot commented Aug 30, 2020

Thank you @lyrixx.

@fabpot fabpot merged commit ba48f00 into symfony:master Aug 30, 2020
@lyrixx lyrixx deleted the workflow-metadata branch August 31, 2020 07:36
@xabbuh xabbuh added this to the next milestone Sep 20, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@fabpot fabpot mentioned this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get metadata configuration from Transition without having to inject the whole graph
7 participants